Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(danger): tweak size reporting #2679

Merged
merged 1 commit into from
Jun 19, 2017
Merged

chore(danger): tweak size reporting #2679

merged 1 commit into from
Jun 19, 2017

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jun 19, 2017

  • adds colorization to reporting (grey for no change, red for size increase, green for size decrease)
  • fixes formatting of decimals for differences

Description:

Related issue (if exists):

- adds colorization to reporting (grey for no change, red for size increase, green for size decrease)
- fixes formatting of decimals for differences
Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 once travis returns green.

@rxjs-bot
Copy link

Messages
📖

CJS: 3161.62KB, global: 585.78KB (gzipped: 107.58KB), min: 138.03KB (gzipped: 29.06KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.734% when pulling c1bd359 on benlesh:tweak-size-reports into 4694a27 on ReactiveX:master.

@kwonoj kwonoj merged commit 53312d7 into ReactiveX:master Jun 19, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants